Skip to content

Comments

win64: build C files with /GS- to avoid "security" calls#5839

Merged
andralex merged 1 commit intodlang:masterfrom
rainers:win64_nogs
Nov 3, 2017
Merged

win64: build C files with /GS- to avoid "security" calls#5839
andralex merged 1 commit intodlang:masterfrom
rainers:win64_nogs

Conversation

@rainers
Copy link
Member

@rainers rainers commented Nov 3, 2017

This avoids some symbol references into the VC compiler runtime and makes it easier to replace it with another runtime.
I suspect there are no similar security checks on other platforms.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@andralex andralex merged commit 690c74d into dlang:master Nov 3, 2017
@MartinNowak MartinNowak added this to the 2.078.0 milestone Dec 12, 2017
@MartinNowak
Copy link
Member

I'm somewhat uneasy about this @rainers, any chance we could stub the necessary methods in toolchains that lack them?
Disabling protections in a library that process user input (zlib) and might not get updated regularly sounds like a bad idea (thx to Iain for the recent updates, https://github.com/dlang/phobos/commits/master/etc/c/zlib/README).
https://www.zlib.net/ChangeLog.txt
-GS (Buffer Security Check)

@rainers
Copy link
Member Author

rainers commented Dec 12, 2017

@MartinNowak I don't think we need to be very pessimistic here. zlib is a pretty well tested library. I suspect there are no such tests on any other platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants