win64.mak: Try to unify source files#5939
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#5939" |
|
We're now hitting the 32k limit ;) IIRC, this year we had to split the object files on Windows 1-2 times, you can look at commit history for details. OptLink needs support at least 128k symbols, IMO in order for us to be certain this won't break later down the road. |
Hmm is this as simple as increasing the constants in the DMD source code or are the 32k a hard limit defined by OPTLINK? |
|
We need changes to optlink and we can't switch away from using it in the short-term. |
|
The problem here is not a limit on the number of symbols (win64 uses COFF, not OMF), but a limit on available memory. I've not yet seen phobos unittest compile to a single object file. Last time I tried it run out of memory/swap space at around 15GB. |
|
Doesn't look like this is ever going to pass :/ |
According to Bugzilla 3372 has been fixed six years ago.
In lack of a machine to test it and as it needs to work on auto-tester anyhow. Here's an attempt to remove the split into different unittest object files. If this works, the next stage would be to put the source files in a separate file which can be imported by
posix.makandwin{32,64}.maklike e.g. it's done at DRuntime.