Skip to content

Comments

win64.mak: Try to unify source files#5939

Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:cleanup-win64
Closed

win64.mak: Try to unify source files#5939
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:cleanup-win64

Conversation

@wilzbach
Copy link
Contributor

According to Bugzilla 3372 has been fixed six years ago.

In lack of a machine to test it and as it needs to work on auto-tester anyhow. Here's an attempt to remove the split into different unittest object files. If this works, the next stage would be to put the source files in a separate file which can be imported by posix.mak and win{32,64}.mak like e.g. it's done at DRuntime.

@wilzbach wilzbach added the Review:WIP Work In Progress - not ready for review or pulling label Dec 18, 2017
@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 18, 2017

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#5939"

@PetarKirov
Copy link
Member

We're now hitting the 32k limit ;)

IIRC, this year we had to split the object files on Windows 1-2 times, you can look at commit history for details.

OptLink needs support at least 128k symbols, IMO in order for us to be certain this won't break later down the road.

@wilzbach wilzbach added Merge:Blocked and removed Review:WIP Work In Progress - not ready for review or pulling labels Dec 18, 2017
@wilzbach
Copy link
Contributor Author

OptLink needs support at least 128k symbols, IMO in order for us to be certain this won't break later down the road.

Hmm is this as simple as increasing the constants in the DMD source code or are the 32k a hard limit defined by OPTLINK?
Is there any chance that we can switch to mscoff?

@PetarKirov
Copy link
Member

We need changes to optlink and we can't switch away from using it in the short-term.

@rainers
Copy link
Member

rainers commented Dec 25, 2017

The problem here is not a limit on the number of symbols (win64 uses COFF, not OMF), but a limit on available memory. I've not yet seen phobos unittest compile to a single object file. Last time I tried it run out of memory/swap space at around 15GB.
BTW: index.d is not a D source file to compile together with the other files, it's a ddoc file. Also, this PR is missing a lot of line continuation \s.

@wilzbach
Copy link
Contributor Author

wilzbach commented Jun 7, 2018

Doesn't look like this is ever going to pass :/

@wilzbach wilzbach closed this Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants