Skip to content

Porting: gammafunction: Add constants for ieeeQuadruple reals#5947

Merged
dlang-bot merged 1 commit intodlang:masterfrom
jpf91:gamma128
Dec 19, 2017
Merged

Porting: gammafunction: Add constants for ieeeQuadruple reals#5947
dlang-bot merged 1 commit intodlang:masterfrom
jpf91:gamma128

Conversation

@jpf91
Copy link
Contributor

@jpf91 jpf91 commented Dec 19, 2017

Setting MAXGAMMA to the same as for ieeeExtended reals means the range of the gamma function will be limited to the same range as ieeeExtended. However, until someone reviews the algorithm to work fine for ieeeQuadruple ranges, this workaround seems fine. We just lose some 128bit real features, but we're still as good as x86.

This is a revival of #4047

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @jpf91! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Setting MAXGAMMA to the same as for ieeeExtended reals means the range
of the gamma function will be limited to the same range as ieeeExtended.
However, until someone reviews the algorithm to work fine for
ieeeQuadruple ranges, this workaround seems fine. We just lose some
128bit real features, but we're still as good as x86.
Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not an expert but lgtm

@dlang-bot dlang-bot merged commit 801fa16 into dlang:master Dec 19, 2017
@jpf91
Copy link
Contributor Author

jpf91 commented Dec 19, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants