Skip to content

Comments

Add PHOBOSSRC urls to std.experimental#6006

Merged
dlang-bot merged 1 commit intodlang:stablefrom
wilzbach:add-urls
Jan 8, 2018
Merged

Add PHOBOSSRC urls to std.experimental#6006
dlang-bot merged 1 commit intodlang:stablefrom
wilzbach:add-urls

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jan 7, 2018

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 7, 2018

#6007 is needed first

@JackStouffer
Copy link
Contributor

Why should this go on stable?

@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 7, 2018

Otherwise it will take two months before it's visible on dlang.org

@JackStouffer
Copy link
Contributor

JackStouffer commented Jan 7, 2018

But it makes the merge back into master more complex. I'm skeptical of putting anything but regression fixes onto stable. CC @MartinNowak

@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 7, 2018

It doesn't. The other way - cherry-picking from master - makes it a bit more complicated. I can submit a merge back into master easily afterwards to show that we don't need to be afraid about this.

@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 8, 2018

I can submit a merge back into master easily afterwards

See also: https://github.com/wilzbach/git-tools/blob/master/merge_stable

@JackStouffer
Copy link
Contributor

I'm assuming this macro is not used for the ddox version because of the auto generated link at the top right?

@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 8, 2018

// Written in the D programming language.
/**
Source: $(PHOBOSSRC std/experimental/allocator/building_blocks/_ascending_page_allocator.d)
*/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> #6009

@dlang-bot dlang-bot merged commit 1f319fe into dlang:stable Jan 8, 2018
@wilzbach wilzbach deleted the add-urls branch January 8, 2018 15:38
@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 8, 2018

I can submit a merge back into master easily afterwards
See also: https://github.com/wilzbach/git-tools/blob/master/merge_stable

#6006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants