std.uni: Replace parameter storage class in by what it should express…#6074
Merged
dlang-bot merged 1 commit intodlang:masterfrom Feb 12, 2018
carblue:std_uni_fix_in
Merged
std.uni: Replace parameter storage class in by what it should express…#6074dlang-bot merged 1 commit intodlang:masterfrom carblue:std_uni_fix_in
dlang-bot merged 1 commit intodlang:masterfrom
carblue:std_uni_fix_in
Conversation
… (const scope, but dmd treats it as const); see also merged dlang.org PR #2126 or issue #17928
Contributor
|
Thanks for your pull request, @carblue! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla references
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (const scope, but dmd treats it as const); see also merged dlang.org PR #2126 or issue #17928
This is a trivial, 'basic' PR in a coming series of PRs dedicated to make std.uni compilable with -dip1000.
Until yesterday's merge of dlang/dlang.org#2126, there was the confusing situatiom, that parameter storage class 'in' was documented in spec as being an equivalent of 'const scope', though dmd treats 'in' as an equivalent of 'const' currently.
Likely, the code author wanted to/should express 'const scope' by using 'in', thus this PR is just a blunt copy-and-paste to sort out the bulk of (-dip1000) compiler errors.
Anyway, I'll check for scope required or not in another pass.