Skip to content

Comments

[WIP] Experiment with generating a header file the unicode_tables#6123

Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:unicode-header
Closed

[WIP] Experiment with generating a header file the unicode_tables#6123
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:unicode-header

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Feb 4, 2018

  1. There's a bug in the header generation with return - will look into that one shortly
  2. It's stil failing with another D header file generation bug :/
> echo "import std.net.curl;" | dmddev -c -o- -
std/uni.d(7002): Error: function std.internal.unicode_tables.isHangL is not accessible from module uni
std/uni.d(10335): Deprecation: std.internal.unicode_tables.TrieEntry(T...) is not visible from module uni
std/uni.d(10335): Deprecation: std.internal.unicode_tables.TrieEntry(T...) is not visible from module uni
std/uni.d(10335): Deprecation: std.internal.unicode_tables.TrieEntry(T...) is not visible from module uni
std/uni.d(7004): Error: function std.internal.unicode_tables.isHangV is not accessible from module uni
std/uni.d(10335): Deprecation: std.internal.unicode_tables.TrieEntry(T...) is not visible from module uni
std/uni.d(10335): Deprecation: std.internal.unicode_tables.TrieEntry(T...) is not visible from module uni
std/uni.d(7008): Error: function std.internal.unicode_tables.isHangT is not accessible from module uni
std/uni.d(7032): Error: function std.internal.unicode_tables.isHangL is not accessible from module uni
std/uni.d(7034): Error: function std.internal.unicode_tables.isHangV is not accessible from module uni
std/uni.d(7048): Error: function std.internal.unicode_tables.isHangV is not accessible from module uni
std/uni.d(7050): Error: function std.internal.unicode_tables.isHangT is not accessible from module uni
std/uni.d(7059): Error: function std.internal.unicode_tables.isHangT is not accessible from module uni
std/uni.d(10335): Deprecation: std.internal.unicode_tables.TrieEntry(T...) is not visible from module uni
std/uni.d(10335): Deprecation: std.internal.unicode_tables.TrieEntry(T...) is not visible from module uni
std/uni.d(10335): Deprecation: std.internal.unicode_tables.TrieEntry(T...) is not visible from module uni
std/uni.d(10335): Deprecation: std.internal.unicode_tables.TrieEntry(T...) is not visible from module uni
std/uni.d(7104): Error: template instance std.uni.genericDecodeGrapheme!false.genericDecodeGrapheme!(const(char)[]) error instantiating
std/format.d(3123):        instantiated from here: graphemeStride!char
std/format.d(2807):        instantiated from here: formatRange!(Appender!string, string, char)
std/format.d(1777):        instantiated from here: formatValueImpl!(Appender!string, string, char)
std/format.d(567):        ... (1 instantiations, -v to show) ...
std/format.d(6115):        instantiated from here: formattedWrite!(Appender!string, char, const(ushort), string, const(ushort), const(ushort))
std/net/curl.d(3295):        instantiated from here: format!(char, const(ushort), string, const(ushort), const(ushort))

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@dlang-bot dlang-bot added the Review:WIP Work In Progress - not ready for review or pulling label Feb 4, 2018
@wilzbach
Copy link
Contributor Author

wilzbach commented Feb 4, 2018

It's stil failing with another D header file generation bug :/

Here's the first PR: dlang/dmd#7835

@wilzbach
Copy link
Contributor Author

wilzbach commented Feb 4, 2018

and another DMD PR is required: dlang/dmd#7836
However, with both PRs this compiles, but doesn't lead to any significant improvement, because even though the tables are private, they are still templated and thus included in the header file :/

@CyberShadow
Copy link
Member

Yeah, I guess there's also that they won't be usable in CTFE when hidden this way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:Blocked Review:WIP Work In Progress - not ready for review or pulling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants