Fix Issue 17982 - Support for const(Class) in algorithm.searching.extremum#6157
Merged
dlang-bot merged 1 commit intodlang:masterfrom Apr 5, 2018
Merged
Fix Issue 17982 - Support for const(Class) in algorithm.searching.extremum#6157dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
wilzbach
requested review from
JackStouffer,
PetarKirov and
andralex
as code owners
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6157" |
wilzbach
commented
Feb 11, 2018
|
|
||
| const(B)[] arr = [new B(0), new B(1)]; | ||
| // can't compare directly - https://issues.dlang.org/show_bug.cgi?id=1824 | ||
| assert(arr.extremum!"a.val".val == 0); |
Contributor
Author
There was a problem hiding this comment.
Imho this is the real bummer - arr.extremum!"a.val" == new B(0) doesn't work :/
std/algorithm/searching.d
Outdated
| int val; | ||
| } | ||
|
|
||
| import std.stdio; |
| this(int val){ this.val = val; } | ||
| } | ||
|
|
||
| const(B) doStuff(const(B)[] v) |
Contributor
Author
There was a problem hiding this comment.
It doesn't need to be called (it's a copy from the bug report).
Anyhow, I added an call of doStuff for "more coverage".
n8sh
approved these changes
Mar 30, 2018
wilzbach
added
the
Merge:72h no objection -> merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.