posix.mak - module specific -dip25/1000 for someModule.test and unittest rules#6195
posix.mak - module specific -dip25/1000 for someModule.test and unittest rules#6195carblue wants to merge 4 commits intodlang:masterfrom carblue:dip1000_3
Conversation
|
Thanks for your pull request and interest in making D better, @carblue! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
Looks good and I'm aware that #6041 is blocking this. CC @CyberShadow @MartinNowak - are you okay with this approach too? |
…st rules; update(1)
…st rules; update(2)
…st rules; update(3)
|
This lacks reply from CyberShadow or MartinNowak for more than 2 weeks, thus closing this PR |
@wilzbach
Discussion about this topic is also in
#6041
#6181
aa represents the current state of "phobos -dip1000 compilability".
I preferred associative array aa entries in the "modulename-notation" (e.g. aa[std.array]) instead of OS-dependant "pathname-notation" (didn't recall whether windows can cope with forward-slashes).$(aa[$ (subst /,.,$(basename $<))])
But this only defers the issue to the call-site (I use Linux, i.e. /):
Used currently in 2 rules, e.g.
$(DMD) -od$ $T $(DFLAGS) $ (aa[$(subst /,.,$(basename $<))]) -main $ (UDFLAGS) $(LIB) -defaultlib= -debuglib= $ (LINKDL) -cov -run $< ;
%.test : %.d $(LIB)
T=
mktemp -d /tmp/.dmd-run-test.XXXXXX&&(
RET=$$? ; rm -rf $$T ; exit $$RET
)
Positioning$(aa[$ (subst /,.,$(basename $<))]) after $ (DFLAGS) resulting in e.g. -dip25 -dip1000 always worked for me, the compiler picked up the last one.