Simplify implementation of errnoEnforce#6289
Merged
dlang-bot merged 1 commit intodlang:masterfrom Mar 19, 2018
Merged
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
JackStouffer
suggested changes
Mar 16, 2018
Contributor
JackStouffer
left a comment
JackStouffer
left a comment
There was a problem hiding this comment.
This is a breaking change, so please add a changelog entry.
JackStouffer
approved these changes
Mar 16, 2018
Contributor
JackStouffer
left a comment
JackStouffer
left a comment
There was a problem hiding this comment.
Sorry, my bad. I misread the signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
enforcenow being an epoynmous template,enforceis a superset oferrnooEnforce.While it might be deputable to deeprecate tthe symbol, we can definitely simplify its implementation which also helps the readers browsing the documentation.
See also:
#6086