[Trivial]std.uni: Fix a -dip1000 compilable issue; appeared since #6041#6294
Merged
wilzbach merged 1 commit intodlang:masterfrom Mar 19, 2018
carblue:std_uni_dip1000
Merged
[Trivial]std.uni: Fix a -dip1000 compilable issue; appeared since #6041#6294wilzbach merged 1 commit intodlang:masterfrom carblue:std_uni_dip1000
wilzbach merged 1 commit intodlang:masterfrom
carblue:std_uni_dip1000
Conversation
Member
|
Seems harmless. But this is strange though as a template should likely infer scope-ness |
DmitryOlshansky
approved these changes
Mar 19, 2018
Contributor
Author
|
Yes, I agree about inferring scope for params in templates and it used to be inferred (and probably will be again). Walter is heavily working on safe/scope issues currently, thus this issue may be only temporary; but it's not the only location where I observed changed safe/scope/dip1000 behavior recently. |
wilzbach
approved these changes
Mar 19, 2018
Contributor
wilzbach
left a comment
There was a problem hiding this comment.
Yeah the compiler should be smarter :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using posix.mak from #6278
make -f posix.mak std/uni.test
results in:
...
sources used (on Linux x86_64):
dmd : Latest commit 17bc56c
druntime: Latest commit f2711a3
phobos : Latest commit 6947d80