Upgrade to DScanner v0.5

.dscanner.ini

@@ -1,5 +1,5 @@
 ; Configure which static analysis checks are enabled
-[analysis.config.StaticAnalysisConfig]
+[dscanner.analysis.config.StaticAnalysisConfig]
 ; Check variable, class, struct, interface, union, and function names against
 ; the Phobos style guide
 style_check="enabled"
@@ -93,6 +93,8 @@ redundant_attributes_check="enabled"
 has_public_example="enabled"
 ; Check for asserts without an explanatory message
 assert_without_msg="skip-unittest"
+; Check indent of if constraints
+if_constraints_indent="enabled"
 
 ; Configure which modules are checked with a specific checker
 ; Please help to extend these checks onto more Phobos modules
@@ -106,7 +108,7 @@ assert_without_msg="skip-unittest"
 ;
 ; Some checks are currently disabled.
 ; For more details, please see https://github.com/dlang/phobos/pull/5501
-[analysis.config.ModuleFilters]
+[dscanner.analysis.config.ModuleFilters]
 ; Check for uses of the old-style alias syntax
 alias_syntax_check="-std.traits,-std.typecons"
 ; Check allman brace style

posix.mak

@@ -82,7 +82,7 @@ ROOT_OF_THEM_ALL = generated
 ROOT = $(ROOT_OF_THEM_ALL)/$(OS)/$(BUILD)/$(MODEL)
 DUB=dub
 TOOLS_DIR=../tools
-DSCANNER_HASH=a230e0fcb166d975cfda168e05a6156dd7db1b41
+DSCANNER_HASH=ef9853215d61731f1a4d97d13618e4cb12c40c57
 DSCANNER_DIR=$(ROOT_OF_THEM_ALL)/dscanner-$(DSCANNER_HASH)
 
 # Set DRUNTIME name and full path

std/algorithm/searching.d

@@ -1378,8 +1378,8 @@ if (isInputRange!Range && !isInfinite!Range &&
 }
 
 private auto extremum(alias selector = "a < b", Range)(Range r)
-    if (isInputRange!Range && !isInfinite!Range &&
-        !is(typeof(unaryFun!selector(ElementType!(Range).init))))
+if (isInputRange!Range && !isInfinite!Range &&
+    !is(typeof(unaryFun!selector(ElementType!(Range).init))))
 {
     return extremum!(a => a, selector)(r);
 }
@@ -1388,9 +1388,9 @@ private auto extremum(alias selector = "a < b", Range)(Range r)
 private auto extremum(alias selector = "a < b", Range,
                       RangeElementType = ElementType!Range)
                      (Range r, RangeElementType seedElement)
-    if (isInputRange!Range && !isInfinite!Range &&
-        !is(CommonType!(ElementType!Range, RangeElementType) == void) &&
-        !is(typeof(unaryFun!selector(ElementType!(Range).init))))
+if (isInputRange!Range && !isInfinite!Range &&
+    !is(CommonType!(ElementType!Range, RangeElementType) == void) &&
+    !is(typeof(unaryFun!selector(ElementType!(Range).init))))
 {
     return extremum!(a => a, selector)(r, seedElement);
 }

std/concurrency.d

@@ -430,7 +430,8 @@ private template isSpawnable(F, T...)
  *  pointer indirection.  This is necessary for enforcing isolation among
  *  threads.
  */
-Tid spawn(F, T...)(F fn, T args) if (isSpawnable!(F, T))
+Tid spawn(F, T...)(F fn, T args)
+if (isSpawnable!(F, T))
 {
     static assert(!hasLocalAliasing!(T), "Aliases to mutable thread-local data not allowed.");
     return _spawn(false, fn, args);
@@ -504,7 +505,8 @@ Tid spawn(F, T...)(F fn, T args) if (isSpawnable!(F, T))
  * Returns:
  *  A Tid representing the new thread.
  */
-Tid spawnLinked(F, T...)(F fn, T args) if (isSpawnable!(F, T))
+Tid spawnLinked(F, T...)(F fn, T args)
+if (isSpawnable!(F, T))
 {
     static assert(!hasLocalAliasing!(T), "Aliases to mutable thread-local data not allowed.");
     return _spawn(true, fn, args);
@@ -513,7 +515,8 @@ Tid spawnLinked(F, T...)(F fn, T args) if (isSpawnable!(F, T))
 /*
  *
  */
-private Tid _spawn(F, T...)(bool linked, F fn, T args) if (isSpawnable!(F, T))
+private Tid _spawn(F, T...)(bool linked, F fn, T args)
+if (isSpawnable!(F, T))
 {
     // TODO: MessageList and &exec should be shared.
     auto spawnTid = Tid(new MessageBox);

std/conv.d

@@ -5974,7 +5974,8 @@ if (isIntegral!T)
 Returns the representation of an enumerated value, i.e. the value converted to
 the base type of the enumeration.
 */
-OriginalType!E asOriginalType(E)(E value) if (is(E == enum))
+OriginalType!E asOriginalType(E)(E value)
+if (is(E == enum))
 {
     return value;
 }

std/digest/crc.d

@@ -159,7 +159,8 @@ alias CRC64ISO = CRC!(64, 0xD800000000000000);
  *
  * See $(D std.digest.digest) for differences between template and OOP API.
  */
-struct CRC(uint N, ulong P) if (N == 32 || N == 64)
+struct CRC(uint N, ulong P)
+if (N == 32 || N == 64)
 {
     private:
         static if (N == 32)

std/experimental/allocator/common.d

@@ -608,8 +608,8 @@ version(unittest)
     }
 
     package void testAllocatorObject(RCAllocInterface)(RCAllocInterface a)
-        if (is(RCAllocInterface == RCIAllocator)
-            || is (RCAllocInterface == shared RCISharedAllocator))
+    if (is(RCAllocInterface == RCIAllocator)
+        || is (RCAllocInterface == shared RCISharedAllocator))
     {
         import std.conv : text;
         import std.math : isPowerOf2;

std/numeric.d

@@ -2610,7 +2610,7 @@ Returns:
     The greatest common divisor of the given arguments.
  */
 T gcd(T)(T a, T b)
-    if (isIntegral!T)
+if (isIntegral!T)
 {
     static if (is(T == const) || is(T == immutable))
     {
@@ -2667,7 +2667,7 @@ T gcd(T)(T a, T b)
 // user-defined types.
 /// ditto
 T gcd(T)(T a, T b)
-    if (!isIntegral!T &&
+if (!isIntegral!T &&
         is(typeof(T.init % T.init)) &&
         is(typeof(T.init == 0 || T.init > 0)))
 {

std/range/package.d

@@ -7808,7 +7808,7 @@ See_Also: $(LREF chunks)
 */
 auto slide(Flag!"withPartial" f = Yes.withPartial,
             Source)(Source source, size_t windowSize, size_t stepSize = 1)
-    if (isForwardRange!Source)
+if (isForwardRange!Source)
 {
     return Slides!(f, Source)(source, windowSize, stepSize);
 }
@@ -7871,7 +7871,7 @@ auto slide(Flag!"withPartial" f = Yes.withPartial,
 }
 
 private struct Slides(Flag!"withPartial" withPartial = Yes.withPartial, Source)
-    if (isForwardRange!Source)
+if (isForwardRange!Source)
 {
 private:
     Source source;

std/regex/internal/backtracking.d

@@ -14,7 +14,7 @@ import std.regex.internal.ir;
     regular expressions.
 +/
 @trusted class BacktrackingMatcher(Char, Stream = Input!Char) : Matcher!Char
-    if (is(Char : dchar))
+if (is(Char : dchar))
 {
     alias DataIndex = Stream.DataIndex;
     struct State