std.algorithm.iteration: Fix a -dip1000 compilable issue#6377
std.algorithm.iteration: Fix a -dip1000 compilable issue#6377dlang-bot merged 1 commit intodlang:masterfrom carblue:std_algorithm_iteration
Conversation
|
Thanks for your pull request and interest in making D better, @carblue! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6377" |
std/range/package.d
Outdated
| return predFun(rhs, lhs); | ||
| } | ||
| private Range _input; | ||
| /*private*/ Range _input; |
There was a problem hiding this comment.
That's not really a proper fix and we shouldn't revert to such hacks :/
There was a problem hiding this comment.
Why does making it public make it safe?
There was a problem hiding this comment.
I just tried this locally and if I set @trusted: to std.container.slist, I can compile + test std.algorithm.iteration successfully with -dip1000 (e.g. pmake std/algorithm/iteration.test)
-> So I suggest to drop this specific change.
https://github.com/dlang/phobos/blob/master/dip1000.mak with
aa[std.algorithm.iteration]=-dip1000
Errors when running: make -f posix.mak std/algorithm/iteration.test
...
The remaining errors are from std/container/slist.d only