Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6391" |
wilzbach
requested review from
CyberShadow,
DmitryOlshansky,
JackStouffer,
MartinNowak,
MetaLang,
PetarKirov,
andralex,
burner,
dnadlinger,
ibuclaw,
jmdavis,
kyllingstad and
schveiguy
as code owners
| $(TDNW $(D )) | ||
| $(TDNW $(D )) | ||
| $(TDNW ``) | ||
| $(TDNW ``) |
There was a problem hiding this comment.
This one is scary.
etc/c/odbc/sql.d
Outdated
| platform-specific instructions and then use the appropriate command-line | ||
| flags (e.g. for dmd, `-L-lodbc` on Posix and `-Lodbc32.lib` on Windows) to link | ||
| with the ODBC library. On Windows, using $(D pragma(lib, "odbc32")) in D | ||
| with the ODBC library. On Windows, using `pragma(lib, "odbc32")` in D |
There was a problem hiding this comment.
Only single-word (no spaces) inline code should be in backquotes. This is because many editors reflow comments automatically, and we don't support backquoted code spanning multiple lines.
There was a problem hiding this comment.
Hmm, smart editors should be able to handle that, but restricted to single-words for now then.
There was a problem hiding this comment.
You mean, smart editors should be able to handle that once someone writes the code for it? I don't think anything is smart enough to do this correctly right now.
|
@JackStouffer rebased though I guess this will easily run into a conflict again... |
|
@wilzbach Rebase and then ping me on slack, and then I'll merge. |
$(D word) -> `word`
|
Thanks! & rebased. |
|
jenkins is still failing due to dlang/ci#190 |
|
DAutoTest shows a lot of diffs, but the diffs reveal that previously the HTML was really broken in some places - text was outright missing. Was a macro previously accidentally undefined? @wilzbach Any idea what happened there? |
|
Fixes Issue 23849 - Ddoc $(LPAREN) and $(RPAREN) not formatted properly Introduced by dlang#6391 in 2018.
5 participants
$(D word) ->
wordDone with: https://github.com/wilzbach/dscanner-fix/blob/master/d_code_markdown.d
Continuation of the first experiment in #5970
Replacement of #5801
CC @andralex
(the script doesn't replace everything, it doesn't try to deal with a few tricky instances. They can be manually looked afterwords.
D_PARAMisn't touched either)