Skip to content

Comments

Allow to add additional DFLAGS when building Phobos#6392

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:dflags
Apr 17, 2018
Merged

Allow to add additional DFLAGS when building Phobos#6392
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:dflags

Conversation

@wilzbach
Copy link
Contributor

dlang/dmd#8089 for Phobos, s.t. downstream packers can set their custom flags and don't need to patch posix.mak like e.g. #5966

It's also useful for quickly applying a flag for local testing:

make -f posix.mak std/algorithm/iteration.test DFLAGS="-debug=MyDebug"

For reference, environment variables aren't read, so global DFLAGS won't start to influence this Makefile, e.g.

DFLAGS="-debug=MyDebug" make -f posix.mak std/algorithm/iteration.test

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6392"

@wilzbach
Copy link
Contributor Author

wilzbach commented Apr 6, 2018

FYI the analog DMD PR has been merged a few days ago now.

Copy link
Contributor

@edi33416 edi33416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@edi33416
Copy link
Contributor

@wilzbach do you think this change would require a changelog or an announcement on the forum? I'm just wondering if there were any folks relying on the previous behaviour: If a variable has been set with a command argument [..], then ordinary assignments in the makefile are ignored.

The same question for the dmd pr

@dlang-bot dlang-bot merged commit 43df8cc into dlang:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants