Allow to add additional DFLAGS when building Phobos#6392
Merged
dlang-bot merged 1 commit intodlang:masterfrom Apr 17, 2018
Merged
Allow to add additional DFLAGS when building Phobos#6392dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6392" |
dac6aec to
4d7dd9f
Compare
Contributor
Author
|
FYI the analog DMD PR has been merged a few days ago now. |
Contributor
|
@wilzbach do you think this change would require a changelog or an announcement on the forum? I'm just wondering if there were any folks relying on the previous behaviour: The same question for the dmd pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dlang/dmd#8089 for Phobos, s.t. downstream packers can set their custom flags and don't need to patch
posix.maklike e.g. #5966It's also useful for quickly applying a flag for local testing:
For reference, environment variables aren't read, so global
DFLAGSwon't start to influence this Makefile, e.g.