Work On Issue 18693 - Remove rndtonl from std.math#6429
Work On Issue 18693 - Remove rndtonl from std.math#6429dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @JackStouffer! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6429" |
|
Looks like ddox is mis-parsing the unittest block and including the next function signature |
(from dlang/DIPs#108) |
wilzbach
left a comment
There was a problem hiding this comment.
Side note: all of these platform specific math functions which share the C names feel a lot like PHP. This is not how these would be designed if std.math was to be written today, so any instance of these that we can remove/redesign, the better.
Fully agreed. std.math would look quite differently today.
|
@andralex could we get your approval on this one? Thanks! |
f32aefe to
0c2173b
Compare
andralex
left a comment
There was a problem hiding this comment.
If semantics are not identical, please specify differences in the deprecation message and changelog. Thanks!
6982c86 to
14ab339
Compare
|
does this function even work at all |
14ab339 to
b4f675f
Compare
Nope. |
This function
roundand friendsSide note: all of these platform specific math functions which share the C names feel a lot like PHP. This is not how these would be designed if std.math was to be written today, so any instance of these that we can remove/redesign, the better.