Expose a copy of std.conv with the DUB package of stdx.allocator#6613
Expose a copy of std.conv with the DUB package of stdx.allocator#6613dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6613" |
|
We should probably split |
| pkgDir.buildPath("std", "conv.d") | ||
| .readText | ||
| .replace("std.conv", "stdx.allocator.conv") | ||
| .toFile(destDir.buildPath("conv.d")); |
There was a problem hiding this comment.
I'm surprised that this works, and I think this can be quite brittle in the future - e.g. emplace may depend on a fix or new feature in some other module. But given that we have a CI to check for such issues, I'd say we're fine for this experimental feature. But these sorts of hacks are not going to be sustainable, so sooner or later we should look into a more future-proof solution.
This little trick is needed as
emplaceRefisn't public (imho it should be, but that's an issue for a different day).With this patch, the collections library builds with a stable DMD/LDC compiler as it now can use the
phobos:allocatorpackage.