Skip to content

Comments

[trivial] Fix AA tests: order of AA elements isn't determined#6628

Merged
wilzbach merged 1 commit intodlang:masterfrom
IgorStepanov:typeinfo-gethash-tohash
Jul 5, 2018
Merged

[trivial] Fix AA tests: order of AA elements isn't determined#6628
wilzbach merged 1 commit intodlang:masterfrom
IgorStepanov:typeinfo-gethash-tohash

Conversation

@IgorStepanov
Copy link
Contributor

Needed for druntime#2243

@dlang-bot dlang-bot added the Review:Trivial typos, formatting, comments label Jul 5, 2018
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @IgorStepanov! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6628"

@wilzbach
Copy link
Contributor

wilzbach commented Jul 5, 2018

CircleCi failure is unrelated, see #6626

@wilzbach wilzbach merged commit e902f3f into dlang:master Jul 5, 2018
@IgorStepanov
Copy link
Contributor Author

@wilzbach Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants