Fix warning in std.range.package - calling without side effects discards return value#6642
Merged
wilzbach merged 1 commit intodlang:masterfrom Jul 26, 2018
JinShil:fix_197107
Merged
Fix warning in std.range.package - calling without side effects discards return value#6642wilzbach merged 1 commit intodlang:masterfrom JinShil:fix_197107
wilzbach merged 1 commit intodlang:masterfrom
JinShil:fix_197107
Conversation
Contributor
|
Thanks for your pull request, @JinShil! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6642" |
JinShil
requested review from
JackStouffer,
PetarKirov,
andralex and
wilzbach
as code owners
wilzbach
approved these changes
Jul 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DMD currently has a bug that is gagging warnings and deprecations. That bug is in the process of being fixed at dlang/dmd#8519, but it has revealed some warnings that need to be resolved in Phobos. This is one.