Skip to content

Remove inout from JSON valuetype getters#6683

Merged
dlang-bot merged 1 commit intodlang:masterfrom
Erikvv:feature/json-remove-inout
Aug 28, 2018
Merged

Remove inout from JSON valuetype getters#6683
dlang-bot merged 1 commit intodlang:masterfrom
Erikvv:feature/json-remove-inout

Conversation

@Erikvv
Copy link
Contributor

@Erikvv Erikvv commented Aug 27, 2018

After feedback of #6682

@Erikvv Erikvv requested a review from CyberShadow as a code owner August 27, 2018 19:59
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Erikvv! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6683"

@n8sh
Copy link
Member

n8sh commented Aug 28, 2018

You've unintentionally included #6682. Other than that, thumbs up.

Copy link
Member

@n8sh n8sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the extra commit, and approved.

@dlang-bot dlang-bot merged commit 4c66e3f into dlang:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants