Remove duplicate of Unqual implementation#6761
Conversation
|
Thanks for your pull request and interest in making D better, @edi33416! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6761" |
|
See how this works with ddoc: public import core.internal.traits : Unqual; |
|
We don't we do this properly and move the entire traits package to druntime? Would be a good opportunity to clean it up too... |
And would be the gain in that? In general, druntime should only have what it needs to have. Phobos is the standard library, not druntime. If something needs to be in druntime, then we can put it there, and then we can look at doing something like we've done here, but druntime is supposed to be small, and we've generally only put stuff there because it had to be there to support the runtime. Moving all of the std.traits there doesn't help with that at all, and druntime doesn't need everything from std.traits. |
druntime's
core.internal.traits.Unqualis a copy of the same code. This PR removes the code duplication and the required double maintenance ofUnqual.