Skip to content

Comments

Remove duplicate of Unqual implementation#6761

Merged
andralex merged 1 commit intodlang:masterfrom
edi33416:reduce_Unqual
Nov 12, 2018
Merged

Remove duplicate of Unqual implementation#6761
andralex merged 1 commit intodlang:masterfrom
edi33416:reduce_Unqual

Conversation

@edi33416
Copy link
Contributor

druntime's core.internal.traits.Unqual is a copy of the same code. This PR removes the code duplication and the required double maintenance of Unqual.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @edi33416! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6761"

@andralex
Copy link
Member

See how this works with ddoc:

public import core.internal.traits : Unqual;

@andralex andralex merged commit 8c52017 into dlang:master Nov 12, 2018
@wilzbach
Copy link
Contributor

We don't we do this properly and move the entire traits package to druntime? Would be a good opportunity to clean it up too...

@jmdavis
Copy link
Member

jmdavis commented Nov 13, 2018

We don't we do this properly and move the entire traits package to druntime? Would be a good opportunity to clean it up too...

And would be the gain in that? In general, druntime should only have what it needs to have. Phobos is the standard library, not druntime. If something needs to be in druntime, then we can put it there, and then we can look at doing something like we've done here, but druntime is supposed to be small, and we've generally only put stuff there because it had to be there to support the runtime. Moving all of the std.traits there doesn't help with that at all, and druntime doesn't need everything from std.traits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants