std.range.primitive.{Autodecoding -> autodecodeStrings}#6932
Merged
WalterBright merged 1 commit intodlang:masterfrom Mar 23, 2019
Merged
std.range.primitive.{Autodecoding -> autodecodeStrings}#6932WalterBright merged 1 commit intodlang:masterfrom
WalterBright merged 1 commit intodlang:masterfrom
Conversation
dnadlinger
requested review from
JackStouffer,
PetarKirov,
andralex and
wilzbach
as code owners
Contributor
|
Thanks for your pull request, @dnadlinger! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6932" |
wilzbach
approved these changes
Mar 23, 2019
wilzbach
reviewed
Mar 23, 2019
std/traits.d
Outdated
| import std.range.primitives : autodecodeStrings; | ||
|
|
||
| enum isAutodecodableString = Autodecoding && (is(T : const char[]) || is(T : const wchar[])) && !isStaticArray!T; | ||
| enum isAutodecodableString = autodecodeStrings && (is(T : const char[]) || is(T : const wchar[])) && !isStaticArray!T; |
Contributor
There was a problem hiding this comment.
std/traits.d(6590:121)[warn]: Line is longer than 120 characters
This follows Phobos naming conventions and is more self-documenting.
dnadlinger
force-pushed
the
autodecode-strings
branch
from
f74e736 to
6b97ae6
Compare
Member
|
It's a manifest constant, we usually capitalize the first letter. |
Contributor
Author
Not true. |
Member
|
It seems dmd does it both ways :-) Anyhow, it doesn't matter to me. |
Contributor
Author
DMD's coding conventions markedly differ from user-facing code. I don't particularly care either, but let's be consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows Phobos naming conventions and is more self-documenting.
The field has just been added by #6930.