Skip to content

Comments

Comment broken test in std/traits.d#6956

Merged
edi33416 merged 1 commit intodlang:masterfrom
RazvanN7:traits
Apr 11, 2019
Merged

Comment broken test in std/traits.d#6956
edi33416 merged 1 commit intodlang:masterfrom
RazvanN7:traits

Conversation

@RazvanN7
Copy link
Collaborator

@RazvanN7 RazvanN7 commented Apr 11, 2019

This currently blocks: dlang/dmd#9585 . The test can be uncommented and fixed after the dmd PR is pulled

@RazvanN7 RazvanN7 requested a review from PetarKirov as a code owner April 11, 2019 07:08
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6956"

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about leaving a quick comment?

@wilzbach
Copy link
Contributor

(just in case the DMD PR gets stuck)

@RazvanN7
Copy link
Collaborator Author

@wilzbach Good idea, thanks. Done.

@edi33416 edi33416 merged commit ef151b3 into dlang:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants