Skip to content

Explicitly link to math library#7050

Merged
dlang-bot merged 1 commit intodlang:masterfrom
marler8997:explicitLibs2
May 31, 2019
Merged

Explicitly link to math library#7050
dlang-bot merged 1 commit intodlang:masterfrom
marler8997:explicitLibs2

Conversation

@marler8997
Copy link
Copy Markdown
Contributor

Second pass of #7021

Looks like we also need -lm.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7050"

@marler8997
Copy link
Copy Markdown
Contributor Author

@thewilsonator can you trigger a rebuild on buildkite? It looks like there a Rebuild button but I don't have permissions.

@thewilsonator
Copy link
Copy Markdown
Contributor

Done.

@dlang-bot dlang-bot merged commit 841541f into dlang:master May 31, 2019
@marler8997 marler8997 deleted the explicitLibs2 branch May 31, 2019 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants