Skip to content

prepare for fix of issue 20138 ("is expression not evaluating correct…#7147

Merged
thewilsonator merged 1 commit intodlang:masterfrom
aG0aep6G:20138
Aug 19, 2019
Merged

prepare for fix of issue 20138 ("is expression not evaluating correct…#7147
thewilsonator merged 1 commit intodlang:masterfrom
aG0aep6G:20138

Conversation

@aG0aep6G
Copy link
Contributor

…ly?")

With issue 20138 fixed, const U and shared U do match const shared T,
and they leave the other qualifier intact. So const shared U must be
attempted first if we want to strip both qualifiers.

This is blocking dlang/dmd#10317.

…ly?")

With issue 20138 fixed, `const U` and `shared U` do match `const shared T`,
and they leave the other qualifier intact. So `const shared U` must be
attempted first if we want to strip both qualifiers.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @aG0aep6G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20138 blocker is expression not evaluating correctly?

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7147"

@TurkeyMan
Copy link
Contributor

This is very strange... I don't understand, but I take your word for it :)

@thewilsonator
Copy link
Contributor

Please make sure this effect is highlighted in a changelog for dlang/dmd#10317

@thewilsonator thewilsonator merged commit ad70ff2 into dlang:master Aug 19, 2019
@aG0aep6G aG0aep6G deleted the 20138 branch August 20, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants