prepare for fix of issue 20138 ("is expression not evaluating correct…#7147
Merged
thewilsonator merged 1 commit intodlang:masterfrom Aug 19, 2019
Merged
prepare for fix of issue 20138 ("is expression not evaluating correct…#7147thewilsonator merged 1 commit intodlang:masterfrom
thewilsonator merged 1 commit intodlang:masterfrom
Conversation
…ly?") With issue 20138 fixed, `const U` and `shared U` do match `const shared T`, and they leave the other qualifier intact. So `const shared U` must be attempted first if we want to strip both qualifiers.
Contributor
|
Thanks for your pull request and interest in making D better, @aG0aep6G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7147" |
Contributor
|
This is very strange... I don't understand, but I take your word for it :) |
Contributor
|
Please make sure this effect is highlighted in a changelog for dlang/dmd#10317 |
thewilsonator
approved these changes
Aug 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ly?")
With issue 20138 fixed,
const Uandshared Udo matchconst shared T,and they leave the other qualifier intact. So
const shared Umust beattempted first if we want to strip both qualifiers.
This is blocking dlang/dmd#10317.