Skip to content

Comments

Some version (unittest) blocks removed#7345

Merged
dlang-bot merged 1 commit intodlang:masterfrom
alexandrumc:rework-version
Jan 13, 2020
Merged

Some version (unittest) blocks removed#7345
dlang-bot merged 1 commit intodlang:masterfrom
alexandrumc:rework-version

Conversation

@alexandrumc
Copy link
Contributor

Please see dlang/druntime#2888

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @alexandrumc! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7345"

@atilaneves atilaneves added the Merge:72h no objection -> merge The PR will be merged if there are no objections raised. label Jan 6, 2020
@dlang-bot dlang-bot merged commit 6b404eb into dlang:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Merge:72h no objection -> merge The PR will be merged if there are no objections raised.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants