Issue 17712 - Add tests & Revert std.conv.toChars workaround for dmd link error#7536
Closed
ntrel wants to merge 1 commit intodlang:masterfrom
Closed
Issue 17712 - Add tests & Revert std.conv.toChars workaround for dmd link error#7536ntrel wants to merge 1 commit intodlang:masterfrom
ntrel wants to merge 1 commit intodlang:masterfrom
Conversation
ntrel
changed the title
ntrel
force-pushed
the
text-toChars
branch
4 times, most recently
from
5003b06 to
bd543a6
Compare
b17712.d is not fixed in dmd, Phobos workaround: 2f20661 dlang#6659 b17712_c13.d was apparently fixed in dmd: c2eefb0d8d850715f492197b0b1a033d9ad5411a dlang/dmd#9636 Add very basic test facility for independent test files.
Contributor
Author
|
Closing this, as the original test case actually fails, even without reverting the workaround (as shown by the test failures). That workaround now seems to be not working and should probably be reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for now.
Once the test cases in dlang/dmd#11300 are mergedThis pull now contains the tests, which use Phobos. I had to edittest/run.shto run them.The dmd bug for the
b17712_c13.dtest case has been fixed in dlang/dmd#9636.The original test case is still unfixed in dmd. The workaround in
std.conv.text, added in #6659 causes unnecessary allocations when there are multiple arguments and >0 integer arguments.Undefined reference to
std.conv.toChars!(10, char, 1, uint).toChars(uint):https://issues.dlang.org/show_bug.cgi?id=17712