Improve behavior of std.socket "soft" unittests#7580
Conversation
|
Thanks for your pull request, @CyberShadow! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7580" |
|
Please change commit message to: "fix Issue 21114" |
CyberShadow
force-pushed
the
pull-20200805-084948
branch
2 times, most recently
from
317469f to
0fe4d28
Compare
…built with -debug=std_socket Reduce noise and false alarms in CI logs. Also improve the printed message on failure, to make it clear that it is likely a random failure, and that the ignored test failure is not what's causing the entire test suite run to fail.
Have a single switch to control whether to test std.socket "in full" or not.
- There is already a copy of the full license text in ../LICENSE_1_0.txt. - There is already a standard "License" DDoc header.
CyberShadow
force-pushed
the
pull-20200805-084948
branch
from
0fe4d28 to
6760a3b
Compare
|
I don't know why @dlang-bot thinks the issue reference is not fixing it. I copied its code to a small program and it correctly detects that |
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
Style target requires cast to have whitespace
Fix cast style. Co-authored-by: Sebastian Wilzbach <seb@wilzba.ch>
Not sure either, my best guess is that the bot is confused with the https://github.com/dlang/dlang-bot/blob/master/source/dlangbot/bugzilla.d#L61 |
Ah, whoops, I must have been looking at the wrong branch. I can reproduce with the code from the current master you linked. |
|
The RegExp was changed recently to cater more for the GH-syntax people are used to, see dlang/dlang-bot@b7efd0b |
Thanks, here's the fix: dlang/dlang-bot#254 |
4 participants
See discussion in #7579 for details.