Skip to content

Fix CI testing of stable branch#7958

Merged
dlang-bot merged 1 commit intodlang:stablefrom
JohanEngelen:fixhmac
Apr 12, 2021
Merged

Fix CI testing of stable branch#7958
dlang-bot merged 1 commit intodlang:stablefrom
JohanEngelen:fixhmac

Conversation

@JohanEngelen
Copy link
Contributor

Original commit on master = 4c13507

References to the local buffer may not be assigned to a
parameter with longer lifetime
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#7958"

@JohanEngelen
Copy link
Contributor Author

Needed to unblock #7937

@dlang-bot dlang-bot merged commit f76a150 into dlang:stable Apr 12, 2021
@JohanEngelen JohanEngelen deleted the fixhmac branch April 13, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants