Skip to content

Replace equalsDigit with isClose#7968

Merged
dlang-bot merged 1 commit intodlang:masterfrom
berni44:equalsdigit_to_isClose
Apr 17, 2021
Merged

Replace equalsDigit with isClose#7968
dlang-bot merged 1 commit intodlang:masterfrom
berni44:equalsdigit_to_isClose

Conversation

@berni44
Copy link
Contributor

@berni44 berni44 commented Apr 15, 2021

isClose does essentially the same as equalsDigit, is faster and doesn't use libc. This change was suggested by @ibuclaw in #7942 (second to last "show resolved" parts).

@berni44 berni44 requested a review from ibuclaw as a code owner April 15, 2021 20:11
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7968"

@berni44 berni44 force-pushed the equalsdigit_to_isClose branch from 36b30a6 to 8a9d889 Compare April 16, 2021 08:27
@berni44 berni44 force-pushed the equalsdigit_to_isClose branch from 8a9d889 to b5d767c Compare April 17, 2021 12:40
@dlang-bot dlang-bot merged commit bb2432f into dlang:master Apr 17, 2021
@berni44 berni44 deleted the equalsdigit_to_isClose branch April 28, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants