Skip to content

Revert "Fix Issue 21456 - std.format does not accept enum member with string base type as template parameter"#8057

Merged
dlang-bot merged 1 commit intomasterfrom
revert-8029-issue_21456
May 10, 2021
Merged

Revert "Fix Issue 21456 - std.format does not accept enum member with string base type as template parameter"#8057
dlang-bot merged 1 commit intomasterfrom
revert-8029-issue_21456

Conversation

@berni44
Copy link
Contributor

@berni44 berni44 commented May 9, 2021

Reverts #8029

See discussion there and discussion in the forum.

… string base type as template parameter"

This reverts commit 974a88a.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21456 normal std.format does not accept enum member with string base type as template parameter

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8057"

@RazvanN7
Copy link
Collaborator

cc @andralex

@dlang-bot dlang-bot merged commit 36221cf into master May 10, 2021
@Geod24 Geod24 deleted the revert-8029-issue_21456 branch May 10, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants