Skip to content

Comments

add scope to parameters of toUTF32 and toUTFImpl#8109

Merged
dlang-bot merged 1 commit intodlang:masterfrom
aG0aep6G:scope-toUTF32
May 20, 2021
Merged

add scope to parameters of toUTF32 and toUTFImpl#8109
dlang-bot merged 1 commit intodlang:masterfrom
aG0aep6G:scope-toUTF32

Conversation

@aG0aep6G
Copy link
Contributor

For dlang/dmd#12010. Part of an ongoing effort to fix issue 20150.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @aG0aep6G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8109"

@dlang-bot dlang-bot merged commit d7bf730 into dlang:master May 20, 2021
@aG0aep6G aG0aep6G deleted the scope-toUTF32 branch May 20, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants