Skip to content

Comments

Add return scope to xml.toType#8117

Merged
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:xml-totype-return
May 29, 2021
Merged

Add return scope to xml.toType#8117
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:xml-totype-return

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented May 29, 2021

Split off from #8113

@dkorpel dkorpel requested a review from andralex as a code owner May 29, 2021 12:22
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8117"

@dlang-bot dlang-bot merged commit f62e725 into dlang:master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants