Fix Issue 22225 - SumType: Some assignments should be able to execute…#8201
Merged
dlang-bot merged 1 commit intodlang:masterfrom Aug 19, 2021
Merged
Fix Issue 22225 - SumType: Some assignments should be able to execute…#8201dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8201" |
maxhaton
approved these changes
Aug 19, 2021
pbackus
added a commit
to pbackus/sumtype
that referenced
this pull request
Aug 20, 2021
Overwriting a SumType's value with a pointer can be @safe so long as the old value is known, at compile time, to be either (a) a non-pointer, or (b) a pointer of the same type as the new value. This change allows such assignments in @safe code, while still forbidding other assignments that overwrite pointers. See also: - https://issues.dlang.org/show_bug.cgi?id=22225 - dlang/phobos#8201 Fixes #67 on Github.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in safe code