Skip to content

std.socket: Always compile slow unit tests #8456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlang-bot merged 1 commit into from
May 8, 2022
Merged

std.socket: Always compile slow unit tests #8456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions std/socket.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,12 @@ version (StdUnittest)
writefln("Ignoring std.socket(%d) test failure (likely caused by flaky environment): %s", line, e.msg);
}
}

// Without debug=std_socket, still compile the slow tests, just don't run them.
debug (std_socket)
private enum runSlowTests = true;
else
private enum runSlowTests = false;
}

/// Base exception thrown by `std.socket`.
Expand Down Expand Up @@ -1698,7 +1704,7 @@ public:
}
});

debug (std_socket)
if (runSlowTests)
softUnittest({
// test failing reverse lookup
const InternetAddress ia = new InternetAddress("255.255.255.255", 80);
Expand Down Expand Up @@ -2633,7 +2639,7 @@ private:

@safe unittest
{
debug (std_socket)
if (runSlowTests)
softUnittest({
import std.datetime.stopwatch;
import std.typecons;
Expand Down