Conversation
|
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8482" |
| install: phobos.zip | ||
| $(CP) phobos.lib phobos64.lib $(DIR)\windows\lib | ||
| install: phobos.zip $(LIB) | ||
| copy /y /b $(LIB) $(DIR)\windows\lib |
There was a problem hiding this comment.
Looks like this is unused - it a) didn't make sure the lib is actually built beforehand, and b) tried to copy a phobos.lib, which should have never existed (no MODEL suffix).
* Remove some unused variables. * Default to a matching MSVC cl.exe & lib.exe in PATH instead of an ancient Visual Studio 2010 installation. * Remove explicit 32-bit recipes, requiring a separate make invocation. Analogous to dlang/druntime#3853.
cl.exe&lib.exein PATH instead of an ancient Visual Studio 2010 installation.Analogous to dlang/druntime#3853.