Skip to content

Comments

std.logger 32 bit unittest race condition fix#8553

Merged
dlang-bot merged 1 commit intodlang:masterfrom
burner:std.logger_32_race_fix
Sep 2, 2022
Merged

std.logger 32 bit unittest race condition fix#8553
dlang-bot merged 1 commit intodlang:masterfrom
burner:std.logger_32_race_fix

Conversation

@burner
Copy link
Member

@burner burner commented Sep 2, 2022

@WalterBright maybe this helps. From the errors I saw, there is a race somewhere on 32 bit.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @burner!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8553"

@dlang-bot dlang-bot merged commit 5b9a904 into dlang:master Sep 2, 2022
@burner
Copy link
Member Author

burner commented Sep 2, 2022

thank you

@pbackus
Copy link
Contributor

pbackus commented Sep 4, 2022

Same test is still failing for me in #8555

@pbackus
Copy link
Contributor

pbackus commented Sep 4, 2022

Judging from the message I saw (foo), the race is between the test modified in this PR and this test, which also accesses sharedLog.

@burner
Copy link
Member Author

burner commented Sep 4, 2022

I think I understand the problem. The created thread executes code after the test is done. It has to be joined before the test is over. I'll create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants