std.logger 32 bit unittest race condition fix#8553
Merged
dlang-bot merged 1 commit intodlang:masterfrom Sep 2, 2022
Merged
Conversation
Contributor
|
Thanks for your pull request, @burner! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8553" |
thewilsonator
approved these changes
Sep 2, 2022
Member
Author
|
thank you |
Contributor
|
Same test is still failing for me in #8555 |
Contributor
|
Judging from the message I saw ( |
Member
Author
|
I think I understand the problem. The created thread executes code after the test is done. It has to be joined before the test is over. I'll create a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@WalterBright maybe this helps. From the errors I saw, there is a race somewhere on 32 bit.