std.logger.core unittest forgotton thread.join#8557
Conversation
|
Thanks for your pull request, @burner! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8557" |
|
Thanks! |
|
Buildkite appears to be stuck on
Maybe try re-running CI? |
std/logger/core.d
Outdated
|
|
||
| () @trusted | ||
| { | ||
| Thread.sleep(dur!"msecs"(10)); |
There was a problem hiding this comment.
It actually might not be required.
Thanks
There was a problem hiding this comment.
I think de should annotate the join as @safe, if we can. Just a note
There was a problem hiding this comment.
Unfortunately it is a virtual method, so adding @safe could break code that overrides it.
no more sleep
burner
force-pushed
the
std.logger_32_race_fix
branch
from
c66f3c8 to
ebde108
Compare
|
thank you all |
|
Does this fix https://issues.dlang.org/show_bug.cgi?id=23286 ? |
As I can't reproduce this bug, Idk. |
7 participants
At this point I'm quite sure that the sporadic unittest errors happen because the created Thread is still active after the unittest is finish. The log message is written after the test is done.
This PR makes the test join the thread.