Fix Issue 24318 - Nullable should support non-copyable objects#8874
Merged
thewilsonator merged 4 commits intodlang:masterfrom Jan 4, 2024
Merged
Fix Issue 24318 - Nullable should support non-copyable objects#8874thewilsonator merged 4 commits intodlang:masterfrom
thewilsonator merged 4 commits intodlang:masterfrom
Conversation
Generally, if a type has a default value, it should be safe to assume that it's OK to call the destructor on a default-initialized variable. The converse is not compatible with `move`, and goes against implementing non-copyable types.
Use `move` directly.
Fixes issue 24318.
Contributor
|
Thanks for your pull request, @CyberShadow! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8874" |
thewilsonator
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6619 (comment)