Skip to content

Revert "Merge pull request #39 from adamdruppe/dtoh"#125

Merged
DmitryOlshansky merged 1 commit intomasterfrom
fixmaster
Jul 26, 2014
Merged

Revert "Merge pull request #39 from adamdruppe/dtoh"#125
DmitryOlshansky merged 1 commit intomasterfrom
fixmaster

Conversation

@andralex
Copy link
Member

This reverts commit 70a242c, reversing
changes made to 44048e6.

This reverts commit 70a242c, reversing
changes made to 44048e6.
@andralex andralex mentioned this pull request Mar 16, 2014
@MartinNowak
Copy link
Member

What was the outcome of the discussion? Should we still revert this.

@AndrewEdwards
Copy link
Contributor

Ping @andralex @adamdruppe, any word on this?

@adamdruppe
Copy link
Contributor

I don't know, but since I basically don't care anymore might as well go ahead with the revert.

My reasoning for getting the original PR in was to get people to actually try it and fix the rest from there based on real world data (the whole agile MVP idea)... but it seems that nobody else really cares either. If I do ever use it, It'll be from my own repo here https://github.com/adamdruppe/dtoh

@mihails-strasuns
Copy link

Considering it has not passed formal review I don't think we should keep it in official repo. If @adamdruppe can pack it as a dub package (and mention in the description that it needs new champion) that would have been appreciated ;)

@mihails-strasuns
Copy link

Currently it looks like those that need it don't want to work on it and those who can work on it don't need it ;)

@MartinNowak
Copy link
Member

Yeah, let's move it to a dub package, simple enough.

DmitryOlshansky added a commit that referenced this pull request Jul 26, 2014
Revert "Merge pull request #39 from adamdruppe/dtoh"
@DmitryOlshansky DmitryOlshansky merged commit de57890 into master Jul 26, 2014
@dnadlinger dnadlinger deleted the fixmaster branch July 31, 2014 20:51
@timotheecour
Copy link
Contributor

Yeah, let's move it to a dub package, simple enough.

unfortunately the move to dub doesn't help fixing https://issues.dlang.org/show_bug.cgi?id=18363 (Issue 18363 - we should autogenerate duplicate “.h” header files in dmd to keep them in sync) since we'd need this in the compiler (unless rules for bootstrapping the compiler to allow dependencies are relaxed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants