Add update_copyright script. by ibuclaw · Pull Request #261 · dlang/tools

ibuclaw · 2017-10-07T16:33:52Z

I've been a bit under the weather today, so I hacked together something that updates all copyright notices in all dmd sources in a consistent manner, with an --update-year/-y to automate updating the copyright year of sources also.

I would have thought that something like this exists, but couldn't see anything at a glance.

dlang-bot · 2017-10-07T16:33:53Z

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + tools#261"

update_copyright.d

wilzbach · 2018-01-01T13:40:15Z

It would probably be good to add this file to the Makefile, s.t. we at least check that the file compiles. Just adding it to the TOOLS list should be enough (there's a default rule to compile single files).

update_copyright.d

CyberShadow · 2018-02-11T10:39:49Z

Woah, that's a lot of code! I guess this would not be simpler as a shell script using sed & co?

CyberShadow · 2018-02-11T10:40:52Z

Please update the table in README.md to include this tool.

ibuclaw · 2018-02-11T10:57:12Z

Woah, that's a lot of code! I guess this would not be simpler as a shell script using sed & co?

All unknown copyright holders (misspellings or variantions of).
Malformed copyright notices.
Copyrights that were wrapped across multiple lines.

Here's a good example: https://github.com/dlang/dmd/pull/7573/files#diff-7a515f2ecfbe92cc486dc15fc82edf0aL2

Now that dmd has had all "bad" copyright notices removed, it should be a simple sed I guess, unless any sneak in over the course of this year.

ibuclaw · 2018-02-11T12:04:45Z

It would probably be good to add this file to the Makefile,

Done.

Please update the table in README.md to include this tool.

Done.

wilzbach · 2018-02-11T13:09:56Z

Yeah from my own experience trying to use sed for the version bump in 2017 - I only got ~85% because in the DMD repo there are all kinds of funny variants of a header comment, so this is definitely useful!

marler8997

Let's get this included so everyone has access to it. If there's problems with it they're easy to fix.

updatecopyright.d

wilzbach

Ready whenever you are.
(unfortunately I'm pretty sure that this script will still require minor update for 2019 :/)

updatecopyright.d

ibuclaw · 2018-05-01T18:30:33Z

Rebased with 32bit fix. I'll check back in on the CI results later.

ibuclaw · 2018-12-17T12:34:20Z

(unfortunately I'm pretty sure that this script will still require minor update for 2019 :/)

It's almost 2019 and I've realised that this still isn't merged.

Just ran this on current dmd sources with -y option. Here's the diff:

diff --git a/src/dmd/backend/aarray.d b/src/dmd/backend/aarray.d
index 6a052d23f..74080838e 100644
--- a/src/dmd/backend/aarray.d
+++ b/src/dmd/backend/aarray.d
@@ -2,7 +2,7 @@
  * Compiler implementation of the
  * $(LINK2 http://www.dlang.org, D programming language).
  *
- * Copyright:   Copyright (c) 2000-2018 by Digital Mars, All Rights Reserved
+ * Copyright:   Copyright (C) 2000-2018 by The D Language Foundation, All Rights Reserved
  * Authors:     $(LINK2 http://www.digitalmars.com, Walter Bright), Dave Fladebo
  * License:     Distributed under the Boost Software License, Version 1.0.
  *              http://www.boost.org/LICENSE_1_0.txt
diff --git a/src/dmd/backend/debugprint.d b/src/dmd/backend/debugprint.d
index d29fe2d34..999de19e1 100644
--- a/src/dmd/backend/debugprint.d
+++ b/src/dmd/backend/debugprint.d
@@ -3,7 +3,7 @@
  * $(LINK2 http://www.dlang.org, D programming language).
  *
  * Copyright:   Copyright (C) 1985-1998 by Symantec
- *              Copyright (c) 2000-2017 by Digital Mars, All Rights Reserved
+ *              Copyright (C) 2000-2018 by The D Language Foundation, All Rights Reserved
  * Authors:     $(LINK2 http://www.digitalmars.com, Walter Bright)
  * License:     $(LINK2 http://www.boost.org/LICENSE_1_0.txt, Boost License 1.0)
  * Source:      $(LINK2 https://github.com/dlang/dmd/blob/master/src/dmd/backend/debug.c, backend/debugprint.d)
diff --git a/src/dmd/backend/divcoeff.d b/src/dmd/backend/divcoeff.d
index 61c21434b..2840f7f71 100644
--- a/src/dmd/backend/divcoeff.d
+++ b/src/dmd/backend/divcoeff.d
@@ -2,7 +2,7 @@
  * Compiler implementation of the
  * $(LINK2 http://www.dlang.org, D programming language).
  *
- * Copyright:   Copyright (c) 2013-2018 by The D Language Foundation, All Rights Reserved
+ * Copyright:   Copyright (C) 2013-2018 by The D Language Foundation, All Rights Reserved
  * Authors:     $(LINK2 http://www.digitalmars.com, Walter Bright)
  * License:     $(LINK2 http://www.boost.org/LICENSE_1_0.txt, Boost License 1.0)
  * Source:      $(LINK2 https://github.com/dlang/dmd/blob/master/src/dmd/backend/divcoeff.d, backend/divcoeff.d)
diff --git a/src/dmd/backend/dlist.d b/src/dmd/backend/dlist.d
index adf17e0ea..0a810adf5 100644
--- a/src/dmd/backend/dlist.d
+++ b/src/dmd/backend/dlist.d
@@ -10,7 +10,7 @@
  *         different lists to 'share' a common tail.
  *
  * Copyright:   Copyright (C) 1986-1990 by Northwest Software
- *              Copyright (c) 1999-2016 by Digital Mars, All Rights Reserved
+ *              Copyright (C) 1999-2018 by The D Language Foundation, All Rights Reserved
  * Authors:     $(LINK2 http://www.digitalmars.com, Walter Bright)
  * License:     $(LINK2 http://www.boost.org/LICENSE_1_0.txt, Boost License 1.0)
  * Source:      $(LINK2 https://github.com/dlang/dmd/blob/master/src/dmd/backend/dlist.d, backend/dlist.d)
diff --git a/src/dmd/backend/dvec.d b/src/dmd/backend/dvec.d
index 03614a7d0..eda65de5d 100644
--- a/src/dmd/backend/dvec.d
+++ b/src/dmd/backend/dvec.d
@@ -4,7 +4,7 @@
  *
  * Simple bit vector implementation.
  *
- * Copyright:   Copyright (c) 2013-2018 by The D Language Foundation, All Rights Reserved
+ * Copyright:   Copyright (C) 2013-2018 by The D Language Foundation, All Rights Reserved
  * Authors:     $(LINK2 http://www.digitalmars.com, Walter Bright)
  * License:     $(LINK2 http://www.boost.org/LICENSE_1_0.txt, Boost License 1.0)
  * Source:      $(LINK2 https://github.com/dlang/dmd/blob/master/src/dmd/backend/dvec.d, backend/dvec.d)
diff --git a/src/dmd/backend/go.d b/src/dmd/backend/go.d
index 9332a609d..9b68a10d2 100644
--- a/src/dmd/backend/go.d
+++ b/src/dmd/backend/go.d
@@ -3,7 +3,7 @@
  * $(LINK2 http://www.dlang.org, D programming language).
  *
  * Copyright:   Copyright (C) 1986-1998 by Symantec
- *              Copyright (c) 2000-2017 by Digital Mars, All Rights Reserved
+ *              Copyright (C) 2000-2018 by The D Language Foundation, All Rights Reserved
  * Authors:     $(LINK2 http://www.digitalmars.com, Walter Bright)
  * License:     Distributed under the Boost Software License, Version 1.0.
  *              http://www.boost.org/LICENSE_1_0.txt
diff --git a/src/dmd/backend/goh.d b/src/dmd/backend/goh.d
index cdec07b9f..ae80711d6 100644
--- a/src/dmd/backend/goh.d
+++ b/src/dmd/backend/goh.d
@@ -3,7 +3,7 @@
  * $(LINK2 http://www.dlang.org, D programming language).
  *
  * Copyright:   Copyright (C) 1986-1998 by Symantec
- *              Copyright (c) 2000-2017 by Digital Mars, All Rights Reserved
+ *              Copyright (C) 2000-2018 by The D Language Foundation, All Rights Reserved
  * Authors:     $(LINK2 http://www.digitalmars.com, Walter Bright)
  * License:     Distributed under the Boost Software License, Version 1.0.
  *              http://www.boost.org/LICENSE_1_0.txt
diff --git a/src/dmd/backend/varstats.di b/src/dmd/backend/varstats.di
index 383a743e8..02d905f40 100644
--- a/src/dmd/backend/varstats.di
+++ b/src/dmd/backend/varstats.di
@@ -2,7 +2,7 @@
  * Compiler implementation of the
  * $(LINK2 http://www.dlang.org, D programming language).
  *
- * Copyright:   Copyright (c) 2015-2017 by Digital Mars, All Rights Reserved
+ * Copyright:   Copyright (C) 2015-2018 by The D Language Foundation, All Rights Reserved
  * Authors:     Rainer Schuetze
  * License:     Distributed under the Boost Software License, Version 1.0.
  *              http://www.boost.org/LICENSE_1_0.txt
diff --git a/src/dmd/root/longdouble.d b/src/dmd/root/longdouble.d
index c9e75db89..5cc6e943f 100644
--- a/src/dmd/root/longdouble.d
+++ b/src/dmd/root/longdouble.d
@@ -1,4 +1,4 @@
-/* Copyright (c) 1999-2017 by Digital Mars
+/* Copyright (C) 1999-2018 by The D Language Foundation, All Rights Reserved
  * All Rights Reserved, written by Rainer Schuetze
  * http://www.digitalmars.com
  * Distributed under the Boost Software License, Version 1.0.

ibuclaw mentioned this pull request Nov 19, 2017

Reassign copyright from Digital Mars to D Language Foundation dlang/dmd#7004

Merged

ibuclaw force-pushed the updatecopyright branch from d4bf7d2 to aac1c4d Compare November 26, 2017 12:12

ibuclaw force-pushed the updatecopyright branch 3 times, most recently from 9f93cfe to cfd4da0 Compare January 1, 2018 11:59

ibuclaw mentioned this pull request Jan 1, 2018

Automatically update copyright years of all sources dlang/dmd#7573

Merged

ibuclaw force-pushed the updatecopyright branch 2 times, most recently from 75bb24e to e03d07c Compare January 1, 2018 13:27

wilzbach reviewed Jan 1, 2018

View reviewed changes

ibuclaw force-pushed the updatecopyright branch 3 times, most recently from 87ff9bb to acc09f0 Compare January 1, 2018 17:09

marler8997 suggested changes Feb 7, 2018

View reviewed changes

ibuclaw force-pushed the updatecopyright branch from acc09f0 to ae673f5 Compare February 11, 2018 09:13

ibuclaw requested a review from CyberShadow as a code owner February 11, 2018 09:13

ibuclaw force-pushed the updatecopyright branch 2 times, most recently from a41968a to f93f673 Compare February 11, 2018 09:33

ibuclaw force-pushed the updatecopyright branch from f93f673 to 285edd2 Compare February 11, 2018 12:04

marler8997 approved these changes Mar 3, 2018

View reviewed changes

PetarKirov reviewed Mar 4, 2018

View reviewed changes

updatecopyright.d Outdated Show resolved Hide resolved

wilzbach approved these changes Mar 26, 2018

View reviewed changes

updatecopyright.d Outdated Show resolved Hide resolved

ibuclaw force-pushed the updatecopyright branch 2 times, most recently from 872b11f to a489aba Compare May 1, 2018 18:27

ibuclaw force-pushed the updatecopyright branch from a489aba to 0436505 Compare May 1, 2018 18:29

Add updatecopyright script.

7f17609

ibuclaw force-pushed the updatecopyright branch from 0436505 to 7f17609 Compare December 17, 2018 12:31

jacob-carlborg approved these changes Dec 17, 2018

View reviewed changes

thewilsonator approved these changes Dec 17, 2018

View reviewed changes

PetarKirov approved these changes Dec 17, 2018

View reviewed changes

PetarKirov merged commit 483a6d3 into dlang:master Dec 17, 2018

ibuclaw deleted the updatecopyright branch December 17, 2018 14:07

Uh oh!

Conversation

ibuclaw commented Oct 7, 2017

Uh oh!

dlang-bot commented Oct 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bugzilla references

Testing this PR locally

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wilzbach commented Jan 1, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CyberShadow commented Feb 11, 2018

Uh oh!

CyberShadow commented Feb 11, 2018

Uh oh!

ibuclaw commented Feb 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ibuclaw commented Feb 11, 2018

Uh oh!

wilzbach commented Feb 11, 2018

Uh oh!

marler8997 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wilzbach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ibuclaw commented May 1, 2018

Uh oh!

ibuclaw commented Dec 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dlang-bot commented Oct 7, 2017 •

edited

Loading

ibuclaw commented Feb 11, 2018 •

edited

Loading