Skip to content

Expect dependencies in same directory to prevent accidental name clashes#287

Closed
ThomasMader wants to merge 1 commit intodlang:masterfrom
ThomasMader:betterDefaults
Closed

Expect dependencies in same directory to prevent accidental name clashes#287
ThomasMader wants to merge 1 commit intodlang:masterfrom
ThomasMader:betterDefaults

Conversation

@ThomasMader
Copy link
Copy Markdown

@ThomasMader ThomasMader commented Jan 7, 2018

I think that it's better to expect the dependency dirs inside the tools directory because it's the only place you can be sure of no problems with the outside world. #250 (comment)

See also #250 (comment) and following comments.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @ThomasMader! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@CyberShadow
Copy link
Copy Markdown
Member

The problem you're trying to solve has workarounds and several solutions, of which this isn't a good one. This will break things for users, and overall not an improvement. See https://github.com/dlang/tools/pull/250/files#r160042841.

@CyberShadow CyberShadow closed this Jan 7, 2018
@ThomasMader
Copy link
Copy Markdown
Author

Yes I came to the realization that it's too much of a cometic change with no real value but much outside noise to be worth it at all.
Thanks.

@ThomasMader ThomasMader deleted the betterDefaults branch January 7, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants