Expect dependencies in same directory to prevent accidental name clashes#287
Expect dependencies in same directory to prevent accidental name clashes#287ThomasMader wants to merge 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @ThomasMader! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
The problem you're trying to solve has workarounds and several solutions, of which this isn't a good one. This will break things for users, and overall not an improvement. See https://github.com/dlang/tools/pull/250/files#r160042841. |
|
Yes I came to the realization that it's too much of a cometic change with no real value but much outside noise to be worth it at all. |
I think that it's better to expect the dependency dirs inside the tools directory because it's the only place you can be sure of no problems with the outside world. #250 (comment)
See also #250 (comment) and following comments.