Skip to content

Verify default compiler in help text matches given default compiler #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlang-bot merged 1 commit into from
Mar 20, 2018
Merged

Verify default compiler in help text matches given default compiler #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions rdmd_test.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,18 @@ void runCompilerAgnosticTests(string rdmdApp, string defaultCompiler, string mod
assert(res.status == 0, res.output);
assert(res.output.canFind("Usage: rdmd [RDMD AND DMD OPTIONS]... program [PROGRAM OPTIONS]..."));

string helpText = res.output;

// verify help text matches expected defaultCompiler
{
enum compilerHelpLine = " --compiler=comp use the specified compiler (e.g. gdmd) instead of ";
auto offset = helpText.indexOf(compilerHelpLine);
assert(offset >= 0);
auto compilerInHelp = helpText[offset + compilerHelpLine.length .. $];
compilerInHelp = compilerInHelp[0 .. compilerInHelp.indexOf('\n')];
assert(defaultCompiler.baseName == compilerInHelp);
}
Copy link

@joseph-wakeling-sociomantic joseph-wakeling-sociomantic Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice additional test, thanks for adding it.

However, if you're thinking that it provides a path to (in future) removing the need for the --rdmd-default-compiler flag ... it won't. See remarks in the earlier PR about why that is.


// run the fallback compiler test (this involves
// searching for the default compiler, so cannot
// be run with other test compilers)
Expand Down