Skip to content

Comments

Added string.d and updated README#21

Merged
CyberShadow merged 1 commit intodlang:masterfrom
JackStouffer:pattern
May 12, 2017
Merged

Added string.d and updated README#21
CyberShadow merged 1 commit intodlang:masterfrom
JackStouffer:pattern

Conversation

@JackStouffer
Copy link
Contributor

@JackStouffer JackStouffer commented May 10, 2017

Added the planned to be deprecated functions from std.string

@JackStouffer JackStouffer mentioned this pull request May 10, 2017
Merged
@JackStouffer
Copy link
Contributor Author

JackStouffer commented May 10, 2017

dlang/phobos#5378

@wilzbach
Copy link
Contributor

wilzbach commented May 10, 2017

FYI: Travis is failing with:

undead 1.0.6+commit.15.g7f04928: building configuration "undead-test-library"...
../../../../../tmp/dub_test_root-d5433945-da6d-4616-91eb-3a4e30701d31.d(11,15): Error: module pattern from file src/undead/pattern.d must be imported with 'import pattern;'
dmd failed with exit code 1.

@JackStouffer
Copy link
Contributor Author

JackStouffer commented May 10, 2017

@wilzbach Fixed

@CyberShadow
Copy link
Member

CyberShadow commented May 11, 2017

Not sure about the file name. I think the structure should mirror that of Phobos', plus s/^std\./undead./. Meaning, this should go into a new string.d file, which could then receive further additions should we decide to deprecate more things from std.string.

@JackStouffer
Copy link
Contributor Author

JackStouffer commented May 11, 2017

@CyberShadow Changed

@JackStouffer JackStouffer changed the title Added pattern.d and updated README Added string.d and updated README May 11, 2017
CyberShadow
CyberShadow approved these changes May 11, 2017
View reviewed changes
win64.mak Outdated
@@ -1,4 +1,4 @@
#_ win32.mak
s#_ win32.mak
Copy link
Member

@CyberShadow CyberShadow May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks accidental

wilzbach
wilzbach approved these changes May 12, 2017
View reviewed changes
Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea of putting stuff into undead, so that people can easily upgrade their codebase during the deprecation phase and keep on using the old stuff without breakage if they really don't care.

Just a minor nit: doFormat has been removed from Phobos last December

README.md
Some individual functions have been moved here prior to their removal from
Phobos. They are

* undead.doformat: Contains the `doFormat` function from std.format
Copy link
Contributor

@wilzbach wilzbach May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doFormat has been removed from Phobos?
dlang/phobos@cf65a3b

Copy link
Contributor Author

@JackStouffer JackStouffer May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the wording here is a bit confusing. Will change

@JackStouffer
Copy link
Contributor Author

JackStouffer commented May 12, 2017

@CyberShadow Other PR is now merged, let's pull this

@CyberShadow CyberShadow merged commit 7684274 into dlang:master May 12, 2017
@JackStouffer JackStouffer deleted the pattern branch May 13, 2017 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyberShadow CyberShadow CyberShadow approved these changes

+1 more reviewer

@wilzbach wilzbach wilzbach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JackStouffer @wilzbach @CyberShadow