Move all dhara header files to the include/dhara folder #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves organization and makes it easier for users to include the necessary headers in their projects. This also ensures that only the relevant header files are added to the include path during compilation. Signed-off-by: Tim Pambor <tim.pambor@codewrights.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves organization and makes it easier for users to include the necessary headers in their projects. This also ensures that only the relevant header files are added to the include path during compilation.
Previously, the convention was to include the entire repository in the include path, which also exposed other headers, e.g.
ecc/hamming.h. This can lead to naming conflicts with other libraries.With this PR, all dhara headers are properly namespaced under
dhara/, so that projects can include headers using#include "dhara/<header>.h"(as before), but no files outside of the dhara namespace are added to the include path during compilation.This change is part of the efforts to make dhara available as a zephyr module.