Skip to content

Conversation

@infotroph
Copy link

Description

  • Include all 4 params in harvest events
  • Move schema out of data/ to shut up R CMD check
  • Specify ensemble_id as a string
  • Quiet an unrelated deprecation warning in the data.land tests while I was looking at it

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Owner

@dlebauer dlebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@infotroph
Copy link
Author

@dlebauer Since this is a PR into your fork, you'll need to do the merge

@dlebauer dlebauer merged commit 0e6b4fd into dlebauer:events_mvp Oct 3, 2025
18 of 26 checks passed
@infotroph infotroph deleted the events_mvp_ckb branch October 26, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants