Add new_expr and free_function to Realize #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @tqchen could you please help to review? |
Member
|
as apache/tvm#3533 we have started to evolve TVM's IR and no longer uses HalideIR. please send an RFC and possibly PR there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Allocate" has new_expr and free_function, but "Realize" doesn't.
They will be used in our TensorCore IR Passes, which are applied before StorageFaltten and try to set new_expr for some buffer allocations. Before StorageFaltten, buffer allocation is represented by "Realize" instead of "Allocate", that's why we need to add them to "Realize" too.
We plan to open the TVM PR for TensorCore IR Passes in 1 or 2 days. It will be very helpful for reviewers or others to try out the TensorCore IR Passes if this PR can be merged before that. Thank you!