[Example][Refactor] Regolden graphsage example for future guide#4186
Merged
jermainewang merged 12 commits intodmlc:masterfrom Jun 30, 2022
Merged
[Example][Refactor] Regolden graphsage example for future guide#4186jermainewang merged 12 commits intodmlc:masterfrom
jermainewang merged 12 commits intodmlc:masterfrom
Conversation
Collaborator
|
To trigger regression tests:
|
Collaborator
Member
|
Will |
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
Member
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
mufeili
reviewed
Jun 29, 2022
Member
|
Done a first pass, some minor comments |
Collaborator
Member
|
@mufeili Addressed your comments expect the ones about inference. I feel that part may be changed quite significantly in the future so we may not want to focus on it too much. Plus, many full graph examples do not need it. |
Collaborator
Author
|
@mufeili @jermainewang |
Collaborator
jermainewang
approved these changes
Jun 30, 2022
Member
|
LGTM. |
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Member
|
I'll just merge it. Don't want to wait for CI, which is currently quite overloaded. |
7 tasks
7 tasks
7 tasks
7 tasks
10 tasks
7 tasks
This was referenced Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify from #4159
Focus on single-GPU, mini-batch node classification task (graphsage/node_classification.py) to ease the iterating process.
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes
Tests
python3 node_classification.py --gpu 0