[CI] Enable DGL cugaph nightly CI#4573
Merged
Rhett-Ying merged 9 commits intodmlc:masterfrom Sep 22, 2022
Merged
Conversation
Collaborator
Collaborator
Collaborator
Author
Collaborator
Contributor
|
@Rhett-Ying, I pushed a fix to your PR here Rhett-Ying#2 and also verified that it runs locally. See below test that i ran: ### Build Command
docker build -f test_cugraph_nightly_file.Dockerfile -t dgl_nightly .
### Test Command
docker run --gpus=all -it dgl_nightly bash -c 'cd /dgl && bash tests/scripts/cugraph_unit_test.sh cugraphFROM rapidsai/cugraph_nightly_torch-cuda:11.5-base-ubuntu18.04-py3.9-pytorch1.12.0-rapids22.10
RUN cd / && git clone https://github.com/dmlc/dgl.git
RUN cd / && cd dgl && git submodule update --init --recursive
RUN cd / && cd dgl && git config --global user.email "vjawa@nvidia.com" && git fetch origin pull/4573/head:PR_4573 && git merge PR_4573
RUN cd /dgl && bash tests/scripts/build_dgl.sh cugraph |
Collaborator
Member
|
One question for the team. I remember we have agreed to have cuGraph as an optional check so it will not block the development. It looks like this PR adds cuGraph to the main pipeline. Does it make cuGraph a mandatory CI check? |
Collaborator
Author
|
this PR aims to update the image used for cugraph. As for making it optional check, it's probably need another PR to achieve this. I don't know how to achieve this for now. |
VibhuJawa
reviewed
Sep 20, 2022
Collaborator
Collaborator
Collaborator
Collaborator
jermainewang
approved these changes
Sep 22, 2022
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on #4525 which breaks the CI. Let me open a new one to be verified by CI automatically. Probably caused bu incorrect
Truewhich should betrueinJenkinsfile. @VibhuJawaChecklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes