Skip to content

fix g++8 warning #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 2 commits into from
Jun 20, 2018
Merged

fix g++8 warning #413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b595519
Fix g++8 warning
tqchen Jun 20, 2018
0fa3b02
fix g++warning
tqchen Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/dmlc/parameter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,7 +994,7 @@ class FieldEntry<float> : public FieldEntryNumeric<FieldEntry<float>, float> {
os << "Invalid Parameter format for " << key_ << " expect " << type_
<< " but value=\'" << value << '\'';
throw dmlc::ParamError(os.str());
} catch (const std::out_of_range) {
} catch (const std::out_of_range&) {
std::ostringstream os;
os << "Out of range value for " << key_ << ", value=\'" << value << '\'';
throw dmlc::ParamError(os.str());
Expand All @@ -1019,7 +1019,7 @@ class FieldEntry<double>
os << "Invalid Parameter format for " << key_ << " expect " << type_
<< " but value=\'" << value << '\'';
throw dmlc::ParamError(os.str());
} catch (const std::out_of_range) {
} catch (const std::out_of_range&) {
std::ostringstream os;
os << "Out of range value for " << key_ << ", value=\'" << value << '\'';
throw dmlc::ParamError(os.str());
Expand Down