Remove the if-statement that sets CMAKE_C_FLAGS to -std=c++0x.#416
Merged
tqchen merged 1 commit intodmlc:masterfrom Jun 24, 2018
JiadingGai:master
Merged
Remove the if-statement that sets CMAKE_C_FLAGS to -std=c++0x.#416tqchen merged 1 commit intodmlc:masterfrom JiadingGai:master
tqchen merged 1 commit intodmlc:masterfrom
JiadingGai:master
Conversation
CMAKE_C_FLAGS are for compiling C files, so you need to set the CMAKE_CXX_FLAGS variable instead. This patch fixes a compilation issue when using clang as the default C compiler.
tqchen
approved these changes
Jun 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_C_FLAGS are for compiling C files, so you need to set the CMAKE_CXX_FLAGS
variable instead. This patch fixes a compilation issue when using clang as the
default C compiler.